[PATCH] lib: fwts_framework: remove dubious total of --show-tests-full

Colin King colin.king at canonical.com
Mon Jul 27 12:59:54 UTC 2015


From: Colin Ian King <colin.king at canonical.com>

show tests full total is not correct as it double accounts for tests
that are under multiple categories.  I am going to remove it because:

1. It is wrong
2. It is more work than can be justified to fix it
3. Probably nobody cares about it anyway

I think less is more in this case.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log | 2 --
 src/lib/src/fwts_framework.c                                    | 2 --
 2 files changed, 4 deletions(-)

diff --git a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log
index 3fd9769..3d0906e 100644
--- a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log
+++ b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log
@@ -827,5 +827,3 @@ UEFI tests:
   Test UEFI RT service set variable interface stress test.
   Test UEFI RT service query variable info interface stress test.
   Test UEFI RT service get variable interface, invalid parameters.
-
-Total of 668 tests
diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
index c3f1dea..b74d3e5 100644
--- a/src/lib/src/fwts_framework.c
+++ b/src/lib/src/fwts_framework.c
@@ -330,8 +330,6 @@ static void fwts_framework_show_tests(fwts_framework *fw, const bool full)
 			fwts_list_free_items(&sorted, NULL);
 		}
 	}
-	if (full)
-		printf("\nTotal of %d tests\n", total);
 }
 
 /*
-- 
2.4.6




More information about the fwts-devel mailing list