ACK: [PATCH] fwts-test: facs: fix repeated offset in data

Alex Hung alex.hung at canonical.com
Mon Jul 6 03:17:54 UTC 2015


On 07/03/2015 08:08 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> A cut-n-paste error when I hand crafted two FACS acpitables
> introduced duplicate offsets.  The current acpidump loader
> in fwts did not detect this, so the parse needs fixing too.
> As for now, fix these test acpitable dumps.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  fwts-test/facs-0001/acpidump-0001.log | 2 +-
>  fwts-test/facs-0001/acpidump-0002.log | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fwts-test/facs-0001/acpidump-0001.log b/fwts-test/facs-0001/acpidump-0001.log
> index 4d5f775..71a3eaf 100644
> --- a/fwts-test/facs-0001/acpidump-0001.log
> +++ b/fwts-test/facs-0001/acpidump-0001.log
> @@ -3,4 +3,4 @@ FACS @ 0x00000000
>    0010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>    0020: 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>    0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> -  0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> +  0040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> diff --git a/fwts-test/facs-0001/acpidump-0002.log b/fwts-test/facs-0001/acpidump-0002.log
> index 6d11ec7..42740c3 100644
> --- a/fwts-test/facs-0001/acpidump-0002.log
> +++ b/fwts-test/facs-0001/acpidump-0002.log
> @@ -2,5 +2,5 @@ FACS @ 0x00000000
>    0000: 46 41 43 53 40 00 00 00 ef be ad de 00 00 00 00  FACS at ...........
>    0010: 00 00 00 00 ff ff ff ff 00 00 00 00 00 00 00 00  ................
>    0020: 01 aa 55 aa ef ef ef ef 00 00 00 00 00 00 00 00  ................
> -  0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>    0030: 00 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> +  0040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list