[PATCH 17/46] bios: multiproc: reduce scope of variables

Colin King colin.king at canonical.com
Tue Jan 13 19:04:36 UTC 2015


From: Colin Ian King <colin.king at canonical.com>

cppcheck is picking up some minor style issues which can
be easily fixed:

[src/bios/multiproc/mpdump.c:300]:
	(style) The scope of the variable 'buffer' can be reduced.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/bios/multiproc/mpdump.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/bios/multiproc/mpdump.c b/src/bios/multiproc/mpdump.c
index 2a57b20..0b22ba9 100644
--- a/src/bios/multiproc/mpdump.c
+++ b/src/bios/multiproc/mpdump.c
@@ -297,11 +297,11 @@ static char *mpdump_find_bus_name(uint8_t bus_id)
 
 static char *mpdump_dst_io_apic(uint8_t apic)
 {
-	static char buffer[4];
-
 	if (apic == 255)
 		return "all";
 	else {
+		static char buffer[4];
+
 		snprintf(buffer, sizeof(buffer), "%d", apic);
 		return buffer;
 	}
-- 
2.1.4




More information about the fwts-devel mailing list