[PATCH 00/46] Clean up warnings found by cppcheck

[Colin King]

From: Colin Ian King <colin.king at canonical.com>

I've run fwts through cppcheck and cleaned up some style
warnings.  Most of these are just cosmetic, but some are
minor bug fixes that slipped through.

Colin Ian King (46):
  acpi: acpidump: reduce scope of variables
  acpi: battery: reduce scope of variables
  acpi: brightness: reduce scope of variables
  acpi: brightness: reduce scope of variables
  acpi: crsdump: reduce scope of variables
  acpi: lid: reduce scope of variables
  utilities: kernelscan: reduce scope of variables
  uefi: uefirtvariable: reduce scope of variables
  acpi: dmar: reduce scope of variables
  acpi: pcc: reduce scope of variables
  acpi: method: reduce scope of variables
  acpi: s3: reduce scope of variables
  acpi: s3power: reduce scope of variables
  acpi: s4: reduce scope of variables
  bios: hdaaudio: reduce scope of variables
  bios: mtrr: reduce scope of variables
  bios: multiproc: reduce scope of variables
  cpu: cpufreq: reduce scope of variables
  cpu: maxfreq: reduce scope of variables
  cpu: microcode: reduce scope of variables
  cpu: msr: reduce scope of variables
  cpu: nx: reduce scope of variables
  hotkey: reduce scope of variables
  hpet: hpet_check: reduce scope of variables
  lib: fwts_acpi_tables: reduce scope of variables
  lib: fwts_backtrace: reduce scope of variables
  lib: fwts_battery: reduce scope of variables
  lib: fwts_dump:	replace asctime with strftime
  lib: fwts_efi_module: reduce scope of variable
  cmos: cmosdump: clarify precedence for & and ?
  lib: fwts_framework: fix some minor style warnings from cppcheck
  lib: fwts_gpe: reduce scope of variables
  lib: fwts_memorymap: fix typo on memory comparison sort
  lib: fwts_memorymap: reduce scope of variables
  lib: fwts_log: reduce scope of variables
  lib: fwts_pm_method: reduce scope of variables
  reduce scope of variables
  lib: fwts_uefi: reduce scope of variables
  pci: aspm: reduce scope of variables
  lib: klog: reduce scope of variables
  uefi: uefibootpath: reduce scope of variables
  uefi: securebootcert: reduce scope of variables
  uefi: uefidump: reduce scope of variables
  uefi: uefirtauthvar: reduce scope of variables
  uefi: uefirtmisc: reduce scope of variables
  uefi: uefivarinfo: reduce scope of variables

 src/acpi/acpidump/acpidump.c             | 14 ++++-----
 src/acpi/battery/battery.c               | 12 ++++----
 src/acpi/brightness/autobrightness.c     |  4 ++-
 src/acpi/brightness/brightness.c         |  7 ++---
 src/acpi/crsdump/crsdump.c               |  9 +++---
 src/acpi/dmar/dmar.c                     | 10 +++----
 src/acpi/lid/lid.c                       | 10 ++++---
 src/acpi/method/method.c                 | 17 ++++++-----
 src/acpi/pcc/pcc.c                       |  3 +-
 src/acpi/s3/s3.c                         |  6 ++--
 src/acpi/s3power/s3power.c               |  8 +++--
 src/acpi/s4/s4.c                         |  9 +++---
 src/bios/hdaaudio/hdaaudio.c             |  9 +++---
 src/bios/mtrr/mtrr.c                     |  4 +--
 src/bios/multiproc/mpdump.c              |  4 +--
 src/cmos/cmosdump/cmosdump.c             | 40 ++++++++++++-------------
 src/cpu/cpufreq/cpufreq.c                |  7 +++--
 src/cpu/maxfreq/maxfreq.c                |  3 +-
 src/cpu/microcode/microcode.c            |  6 ++--
 src/cpu/msr/msr.c                        |  3 +-
 src/cpu/nx/nx.c                          | 10 ++++---
 src/hotkey/hotkey/hotkey.c               |  5 ++--
 src/hpet/hpet_check/hpet_check.c         |  4 +--
 src/lib/src/fwts_acpi_tables.c           | 20 +++++++------
 src/lib/src/fwts_backtrace.c             |  6 ++--
 src/lib/src/fwts_battery.c               |  3 +-
 src/lib/src/fwts_dump.c                  |  8 ++---
 src/lib/src/fwts_efi_module.c            |  3 +-
 src/lib/src/fwts_framework.c             | 11 ++++---
 src/lib/src/fwts_gpe.c                   |  6 ++--
 src/lib/src/fwts_klog.c                  | 14 +++++----
 src/lib/src/fwts_log.c                   | 12 ++++----
 src/lib/src/fwts_memorymap.c             | 11 ++++---
 src/lib/src/fwts_pm_method.c             |  8 +++--
 src/lib/src/fwts_summary.c               |  6 ++--
 src/lib/src/fwts_uefi.c                  |  2 +-
 src/pci/aspm/aspm.c                      |  4 +--
 src/uefi/securebootcert/securebootcert.c |  3 +-
 src/uefi/uefibootpath/uefibootpath.c     |  3 +-
 src/uefi/uefidump/uefidump.c             | 17 ++++++-----
 src/uefi/uefirtauthvar/uefirtauthvar.c   | 51 ++++++++++++++++----------------
 src/uefi/uefirtmisc/uefirtmisc.c         |  8 ++---
 src/uefi/uefirtvariable/uefirtvariable.c |  6 ++--
 src/uefi/uefivarinfo/uefivarinfo.c       |  3 +-
 src/utilities/kernelscan.c               | 16 ++++------
 45 files changed, 226 insertions(+), 199 deletions(-)

-- 
2.1.4