ACK: [PATCH 7/9] acpica: fwts_acpica: remove redundant store to length

ivanhu ivan.hu at canonical.com
Wed Dec 16 06:49:39 UTC 2015



On 2015年12月16日 08:51, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Static analysis from clang scan-build detected a redundant
> store to length, it is set in various places later on in the
> ACPI_ADR_SPACE_SMBUS and ACPI_ADR_SPACE_GSBUS cases, so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpica/fwts_acpica.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index 3caeda9..77a96ca 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -271,7 +271,6 @@ static ACPI_STATUS fwts_region_handler(
>   	fwts_acpi_region_handler_called_set(true);
>
>   	context = ACPI_CAST_PTR (ACPI_CONNECTION_INFO, handlercontext);
> -	length = (ACPI_SIZE)regionobject->Region.Length;
>
>   	switch (regionobject->Region.SpaceId) {
>   	case ACPI_ADR_SPACE_SYSTEM_IO:
>

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list