ACK: [PATCH 4/9] lib: fwts_acpi_table: remove redundant store to rsdt

Alex Hung alex.hung at canonical.com
Wed Dec 16 03:49:05 UTC 2015


On 2015-12-16 08:51 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Static analysis from clang scan-build found a redundant store
> to rsdt that can be removed.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index 42aefcc..0a1af13 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -994,7 +994,6 @@ static int fwts_acpi_load_tables_fixup(fwts_framework *fw)
>   		return FWTS_ERROR;
>   	}
>   	if (table) {
> -		rsdt = (fwts_acpi_table_rsdt *)table->data;
>   		rsdt_fake_addr = table->addr;
>   	} else {
>   		/* No RSDT? go and fake one */
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list