[PATCH] acpi: acpidump: check for fwts_iasl_init failure

Colin King colin.king at canonical.com
Mon Dec 14 13:40:37 UTC 2015


From: Colin Ian King <colin.king at canonical.com>

Forgot to check for fwts_iasl_init failure, add in a test abort
message if it fails.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/acpidump/acpidump.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
index 765cf9f..d49b7a2 100644
--- a/src/acpi/acpidump/acpidump.c
+++ b/src/acpi/acpidump/acpidump.c
@@ -110,7 +110,10 @@ static int acpidump_test1(fwts_framework *fw)
 	int i;
 
 	fwts_infoonly(fw);
-	fwts_iasl_init(fw);
+	if (fwts_iasl_init(fw) != FWTS_OK) {
+		fwts_aborted(fw, "Failure to initialise iasl, aborting.");
+		return FWTS_ERROR;
+	}
 
 	for (i = 0; i < ACPI_MAX_TABLES; i++) {
 		fwts_acpi_table_info *table;
-- 
2.6.4




More information about the fwts-devel mailing list