ACK: [PATCH 3/3] uefidump: add dumping for the ramdisk device path

[Alex Hung]

On 12/03/2015 05:02 PM, Ivan Hu wrote:
> Add dumping with uefi spec. 2.5 for new media device path, Ramdisk device path
>
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>   src/uefi/uefidump/uefidump.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index dc4fa0f..00e1e00 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -631,6 +631,23 @@ static char *uefidump_build_dev_path(char *path, fwts_uefi_dev_path *dev_path, c
>   					r->starting_offset, r->ending_offset);
>   			}
>   			break;
> +		case FWTS_UEFI_RAM_DISK_SUBTYPE:
> +			if (dev_path_len >= sizeof(fwts_ram_disk_path)) {
> +				fwts_ram_disk_path *r = (fwts_ram_disk_path *)dev_path;
> +				path = uefidump_vprintf(path, "\\RAMDISK("
> +					"0x%" PRIx64 ",0x%" PRIx64
> +					"%08" PRIx32 "-%04" PRIx16 "-%04" PRIx16 "-"
> +					"%02" PRIx8 "-%02" PRIx8 "-"
> +					"%02" PRIx8 "-%02" PRIx8 "-%02" PRIx8 "-%02" PRIx8 "-%02" PRIx8 "-%02" PRIx8
> +					",0x%" PRIx16 ")",
> +					r->starting_addr, r->ending_addr,
> +					r->disk_type_guid.info1, r->disk_type_guid.info2, r->disk_type_guid.info3,
> +					r->disk_type_guid.info4[0], r->disk_type_guid.info4[1], r->disk_type_guid.info4[2],
> +					r->disk_type_guid.info4[3], r->disk_type_guid.info4[4], r->disk_type_guid.info4[5],
> +					r->disk_type_guid.info4[6], r->disk_type_guid.info4[7],
> +					r->disk_instance);
> +			}
> +			break;
>   		default:
>   			path = uefidump_vprintf(path, "\\Unknown-MEDIA-DEV-PATH(0x%" PRIx8 ")", dev_path->subtype);
>   			break;
>


Acked-by: Alex Hung <alex.hung at canonical.com>