ACK: [PATCH] acpi: dbg2: won't find obj when no namespace device path (lp: #1486893)

[Colin Ian King]

On 20/08/15 01:58, Ivan Hu wrote:
> The spec. tells that for NamespaceString, if no namespace device exists,
> NamespaceString[] must contain a period “.”, serching obj with a period will
> get the false alarm below:
>  dbg2: DBG2 Device '_____.____' not found in ACPI object name space.
> 
> Skip finding object with dbg2_obj_find function, if no namespace device path
> exists.
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/acpi/dbg2/dbg2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c
> index f5b28c1..1c023a4 100644
> --- a/src/acpi/dbg2/dbg2.c
> +++ b/src/acpi/dbg2/dbg2.c
> @@ -320,7 +320,8 @@ static int dbg2_test1(fwts_framework *fw)
>  			char *str = (char *)table->data + offset + info->namespace_offset;
>  			dbg2_check_namespace_string(fw, str, info->namespace_length, &passed);
>  			fwts_log_info_verbatum(fw, "  Namespace String:         '%s'", str);
> -			dbg2_obj_find(fw, str, &ok);
> +			if (strcmp(str, "."))
> +				dbg2_obj_find(fw, str, &ok);
>  		}
>  		passed &= ok;
>  
> 

Thanks!

Acked-by: Colin Ian King <colin.king at canonical.com>