ACK: [PATCH] acpi: gpedump: clarify precedence for & and ?

ivanhu ivan.hu at canonical.com
Thu Aug 6 07:10:23 UTC 2015



On 2015年08月05日 15:33, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> cppcheck is warning about style issues:
>
> [src/acpi/gpedump/gpedump.c:90]: (style)
> 	Clarify calculation precedence for '&' and '?'.
> [src/acpi/gpedump/gpedump.c:91]: (style)
> 	Clarify calculation precedence for '&' and '?'.
>
> Simple fix to clarify the precendence.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/gpedump/gpedump.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/gpedump/gpedump.c b/src/acpi/gpedump/gpedump.c
> index 19da8d2..14931e4 100644
> --- a/src/acpi/gpedump/gpedump.c
> +++ b/src/acpi/gpedump/gpedump.c
> @@ -87,8 +87,8 @@ static void gpu_dump_gpes(
>   			gpe_block_info->BlockBaseNumber + gpe);
>   		fwts_log_info_verbatum(fw, "        Flags:    0x%2.2" PRIx8 " (trigger: %s, wake: %s)",
>   			GpeEventInfo->Flags,
> -			GpeEventInfo->Flags & ACPI_GPE_LEVEL_TRIGGERED ? "level" : "edge",
> -			GpeEventInfo->Flags & ACPI_GPE_CAN_WAKE ? "can wake" : "run only");
> +			(GpeEventInfo->Flags & ACPI_GPE_LEVEL_TRIGGERED) ? "level" : "edge",
> +			(GpeEventInfo->Flags & ACPI_GPE_CAN_WAKE) ? "can wake" : "run only");
>   		fwts_log_info_verbatum(fw, "        Dispatch: %s", buf);
>   	}
>   }

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list