ACK: [PATCH] dmi: dmicheck: add 4 new DMI chassis types

[Alex Hung]

On 15-04-23 10:35 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Keep chassis types sync'd with DMI spec 3.0.0 (DSP0134, 2015-02-12).
> Also fix typo on one of the constants:
> 	FWTS_SMBIOS_CHASSIS_BLASE_ENCLOSURE ->
> 	FWTS_SMBIOS_CHASSIS_BLADE_ENCLOSURE
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/dmi/dmicheck/dmicheck.c   | 5 ++++-
>   src/lib/include/fwts_smbios.h | 5 ++++-
>   2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index ace7b9e..5fabca0 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -236,7 +236,10 @@ static const fwts_chassis_type_map fwts_dmi_chassis_type[] = {
>   	{ "Compact PCI",	FWTS_SMBIOS_CHASSIS_COMPACT_PCI,		CHASSIS_OTHER },
>   	{ "Advanced TCA",	FWTS_SMBIOS_CHASSIS_ADVANCED_TCA,		CHASSIS_OTHER },
>   	{ "Blade",		FWTS_SMBIOS_CHASSIS_BLADE,			CHASSIS_SERVER },
> -	{ "Enclosure",		FWTS_SMBIOS_CHASSIS_BLASE_ENCLOSURE,		CHASSIS_SERVER }
> +	{ "Enclosure",		FWTS_SMBIOS_CHASSIS_BLADE_ENCLOSURE,		CHASSIS_SERVER },
> +	{ "Tablet",		FWTS_SMBIOS_CHASSIS_TABLET,			CHASSIS_MOBILE },
> +	{ "Convertible",	FWTS_SMBIOS_CHASSIS_CONVERTIBLE,		CHASSIS_MOBILE },
> +	{ "Detachable",		FWTS_SMBIOS_CHASSIS_DETACHABLE,			CHASSIS_MOBILE },
>   };
>   
>   static const fwts_chassis_type_map fwts_acpi_pm_profile_type[] = {
> diff --git a/src/lib/include/fwts_smbios.h b/src/lib/include/fwts_smbios.h
> index 7fc84e6..0d929b8 100644
> --- a/src/lib/include/fwts_smbios.h
> +++ b/src/lib/include/fwts_smbios.h
> @@ -56,7 +56,10 @@
>   #define FWTS_SMBIOS_CHASSIS_COMPACT_PCI			(0x1A)
>   #define FWTS_SMBIOS_CHASSIS_ADVANCED_TCA		(0x1B)
>   #define FWTS_SMBIOS_CHASSIS_BLADE			(0x1C)
> -#define FWTS_SMBIOS_CHASSIS_BLASE_ENCLOSURE		(0x1D)
> +#define FWTS_SMBIOS_CHASSIS_BLADE_ENCLOSURE		(0x1D)
> +#define FWTS_SMBIOS_CHASSIS_TABLET			(0x1E)
> +#define FWTS_SMBIOS_CHASSIS_CONVERTIBLE			(0x1F)
> +#define FWTS_SMBIOS_CHASSIS_DETACHABLE			(0x20)
>   
>   typedef enum {
>   	FWTS_SMBIOS_UNKNOWN = -1,

    Acked-by: Alex Hung <alex.hung at canonical.com>