ACK: [PATCH 1/2] fwts-test: fix up acpitables tests

Alex Hung alex.hung at canonical.com
Wed Apr 1 01:16:31 UTC 2015



On 15-03-31 06:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Commit d70301cd98ebd65bf6d55a2fbfbc85cda20a3c78 recently added
> the GTDT table test, so we need to keep te acpitables test
> in sync with this change
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   fwts-test/acpitables-0001/acpitables-0001.log | 1 +
>   fwts-test/acpitables-0002/acpitables-0001.log | 1 +
>   fwts-test/acpitables-0003/acpitables-0001.log | 1 +
>   fwts-test/acpitables-0004/acpitables-0001.log | 1 +
>   fwts-test/acpitables-0005/acpitables-0001.log | 1 +
>   fwts-test/acpitables-0006/acpitables-0001.log | 1 +
>   fwts-test/acpitables-0007/acpitables-0001.log | 1 +
>   fwts-test/acpitables-0008/acpitables-0001.log | 1 +
>   8 files changed, 8 insertions(+)
>
> diff --git a/fwts-test/acpitables-0001/acpitables-0001.log b/fwts-test/acpitables-0001/acpitables-0001.log
> index 9419c2e..ed2e5cc 100644
> --- a/fwts-test/acpitables-0001/acpitables-0001.log
> +++ b/fwts-test/acpitables-0001/acpitables-0001.log
> @@ -4,6 +4,7 @@ acpitables      Test 1 of 2: Test ACPI tables.
>   acpitables      PASSED: Test 1, Table APIC passed.
>   acpitables      Table ECDT not present to check.
>   acpitables      PASSED: Test 1, Table FACP passed.
> +acpitables      Table GTDT not present to check.
>   acpitables      PASSED: Test 1, Table HPET passed.
>   acpitables      PASSED: Test 1, Table MCFG passed.
>   acpitables      PASSED: Test 1, Table RSDT passed.
> diff --git a/fwts-test/acpitables-0002/acpitables-0001.log b/fwts-test/acpitables-0002/acpitables-0001.log
> index fda4609..40418c8 100644
> --- a/fwts-test/acpitables-0002/acpitables-0001.log
> +++ b/fwts-test/acpitables-0002/acpitables-0001.log
> @@ -5,6 +5,7 @@ acpitables      Cannot find FACP.
>   acpitables      PASSED: Test 1, Table APIC passed.
>   acpitables      Table ECDT not present to check.
>   acpitables      Table FACP not present to check.
> +acpitables      Table GTDT not present to check.
>   acpitables      Table HPET not present to check.
>   acpitables      Table MCFG not present to check.
>   acpitables      Table RSDT not present to check.
> diff --git a/fwts-test/acpitables-0003/acpitables-0001.log b/fwts-test/acpitables-0003/acpitables-0001.log
> index f3cd415..e516732 100644
> --- a/fwts-test/acpitables-0003/acpitables-0001.log
> +++ b/fwts-test/acpitables-0003/acpitables-0001.log
> @@ -65,6 +65,7 @@ acpitables      correctly then ACPI writes to this register *may* nor work
>   acpitables      correctly, meaning a reboot via this mechanism may not
>   acpitables      work.
>   acpitables
> +acpitables      Table GTDT not present to check.
>   acpitables      Table HPET not present to check.
>   acpitables      Table MCFG not present to check.
>   acpitables      PASSED: Test 1, Table RSDT passed.
> diff --git a/fwts-test/acpitables-0004/acpitables-0001.log b/fwts-test/acpitables-0004/acpitables-0001.log
> index b34c0cf..3664e12 100644
> --- a/fwts-test/acpitables-0004/acpitables-0001.log
> +++ b/fwts-test/acpitables-0004/acpitables-0001.log
> @@ -5,6 +5,7 @@ acpitables      Cannot find FACP.
>   acpitables      Table APIC not present to check.
>   acpitables      Table ECDT not present to check.
>   acpitables      Table FACP not present to check.
> +acpitables      Table GTDT not present to check.
>   acpitables      FAILED [MEDIUM] HPETBaseZero: Test 1, HPET base is
>   acpitables      0x000000000000, which is invalid.
>   acpitables      FAILED [MEDIUM] HPETVendorIdZero: Test 1, HPET PCI Vendor
> diff --git a/fwts-test/acpitables-0005/acpitables-0001.log b/fwts-test/acpitables-0005/acpitables-0001.log
> index 41510e2..39d9388 100644
> --- a/fwts-test/acpitables-0005/acpitables-0001.log
> +++ b/fwts-test/acpitables-0005/acpitables-0001.log
> @@ -5,6 +5,7 @@ acpitables      Cannot find FACP.
>   acpitables      Table APIC not present to check.
>   acpitables      Table ECDT not present to check.
>   acpitables      Table FACP not present to check.
> +acpitables      Table GTDT not present to check.
>   acpitables      Table HPET not present to check.
>   acpitables      PASSED: Test 1, Table MCFG passed.
>   acpitables      Table RSDT not present to check.
> diff --git a/fwts-test/acpitables-0006/acpitables-0001.log b/fwts-test/acpitables-0006/acpitables-0001.log
> index cafd379..f25a669 100644
> --- a/fwts-test/acpitables-0006/acpitables-0001.log
> +++ b/fwts-test/acpitables-0006/acpitables-0001.log
> @@ -5,6 +5,7 @@ acpitables      Cannot find FACP.
>   acpitables      Table APIC not present to check.
>   acpitables      Table ECDT not present to check.
>   acpitables      Table FACP not present to check.
> +acpitables      Table GTDT not present to check.
>   acpitables      Table HPET not present to check.
>   acpitables      Table MCFG not present to check.
>   acpitables      FAILED [HIGH] RSDTEntryNull: Test 1, RSDT Entry 1 is null,
> diff --git a/fwts-test/acpitables-0007/acpitables-0001.log b/fwts-test/acpitables-0007/acpitables-0001.log
> index 11fb6a4..10b4c17 100644
> --- a/fwts-test/acpitables-0007/acpitables-0001.log
> +++ b/fwts-test/acpitables-0007/acpitables-0001.log
> @@ -5,6 +5,7 @@ acpitables      Cannot find FACP.
>   acpitables      Table APIC not present to check.
>   acpitables      Table ECDT not present to check.
>   acpitables      Table FACP not present to check.
> +acpitables      Table GTDT not present to check.
>   acpitables      Table HPET not present to check.
>   acpitables      Table MCFG not present to check.
>   acpitables      Table RSDT not present to check.
> diff --git a/fwts-test/acpitables-0008/acpitables-0001.log b/fwts-test/acpitables-0008/acpitables-0001.log
> index b6de722..fbdfc67 100644
> --- a/fwts-test/acpitables-0008/acpitables-0001.log
> +++ b/fwts-test/acpitables-0008/acpitables-0001.log
> @@ -5,6 +5,7 @@ acpitables      Cannot find FACP.
>   acpitables      Table APIC not present to check.
>   acpitables      Table ECDT not present to check.
>   acpitables      Table FACP not present to check.
> +acpitables      Table GTDT not present to check.
>   acpitables      Table HPET not present to check.
>   acpitables      Table MCFG not present to check.
>   acpitables      Table RSDT not present to check.

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list