ACK: [PATCH] acpi: method: add check for _PSL

[Colin Ian King]

On 12/09/14 07:00, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/acpi/method/method.c | 28 ++++++++++++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 1e78e66..d3c2a13 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -166,7 +166,7 @@
>   * _PSC  7.2.6		Y
>   * _PSD  8.4.4.5	N
>   * _PSE  7.2.7		Y
> - * _PSL  11.4.8		N
> + * _PSL  11.4.8		Y
>   * _PSR  10.3.1		Y
>   * _PSS  8.4.4.2	Y
>   * _PSV  11.4.9		Y
> @@ -4434,6 +4434,30 @@ method_test_THERM(_NTT, METHOD_OPTIONAL)
>  method_test_THERM(_PSV, METHOD_OPTIONAL)
>  method_test_THERM(_TST, METHOD_OPTIONAL)
>  
> +static void method_test_PSL_return(
> +	fwts_framework *fw,
> +	char *name,
> +	ACPI_BUFFER *buf,
> +	ACPI_OBJECT *obj,
> +	void *private)
> +{
> +	FWTS_UNUSED(private);
> +
> +	if (method_check_type(fw, name, buf, ACPI_TYPE_PACKAGE) != FWTS_OK)
> +		return;
> +
> +	if (method_package_elements_all_type(fw, name, "_PSL", obj, ACPI_TYPE_LOCAL_REFERENCE) != FWTS_OK)
> +		return;
> +
> +	method_passed_sane(fw, name, "package");
> +}
> +
> +static int method_test_PSL(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_PSL", NULL, 0, method_test_PSL_return, "_PSL");
> +}
> +
>  static void method_test_TRT_return(
>  	fwts_framework *fw,
>  	char *name,
> @@ -5453,7 +5477,7 @@ static fwts_framework_minor_test method_tests[] = {
>  	{ method_test_DTI, "Test _DTI (Device Temperature Indication)." },
>  	{ method_test_HOT, "Test _HOT (Hot Temperature)." },
>  	{ method_test_NTT, "Test _NTT (Notification Temp Threshold)." },
> -	/* { method_test_PSL, "Test _PSL (Passive List)." }, */
> +	{ method_test_PSL, "Test _PSL (Passive List)." },
>  	{ method_test_PSV, "Test _PSV (Passive Temp)." },
>  	{ method_test_RTV, "Test _RTV (Relative Temp Values)." },
>  	{ method_test_SCP, "Test _SCP (Set Cooling Policy)." },
> 
Acked-by: Colin Ian King <colin.king at canonical.com>