ACK: [PATCH 2/4] cpu: cpufreq: print MHz as float, remove erroneous rounding
Alex Hung
alex.hung at canonical.com
Wed May 28 03:29:55 UTC 2014
On 05/23/2014 08:42 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Print MHz frequencies as floats, like the GHz ranges too.
>
> The original code rounded up the integer values when being divided
> down by GHz or Mhz values, but this is wrong for floating point values
> so remove this.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> src/cpu/cpufreq/cpufreq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/cpu/cpufreq/cpufreq.c b/src/cpu/cpufreq/cpufreq.c
> index 39d22ae..91e44f9 100644
> --- a/src/cpu/cpufreq/cpufreq.c
> +++ b/src/cpu/cpufreq/cpufreq.c
> @@ -177,11 +177,11 @@ static char *hz_to_human(const uint64_t hz)
>
> if (hz > 1000000) {
> snprintf(buffer, sizeof(buffer), "%6.3f GHz",
> - (hz+50000.0) / 1000000);
> + (double)hz / 1000000.0);
> return buffer;
> } else if (hz > 1000) {
> - snprintf(buffer, sizeof(buffer), "%" PRIu64 " MHz",
> - (hz+500) / 1000);
> + snprintf(buffer, sizeof(buffer), "%6.3f MHz",
> + (double)hz / 1000.0);
> return buffer;
> } else {
> snprintf(buffer, sizeof(buffer), "%" PRIu64 " Hz", hz);
>
Acked-by: Alex Hung <alex.hung at canonical.com>
More information about the fwts-devel
mailing list