[PATCH] acpica: update to version 20140424 (LP: #1312351)

Alex Hung alex.hung at canonical.com
Thu May 8 02:11:11 UTC 2014


I downloaded the latest source code of V14.05.00, applied the acpica
20140424 patch, resolved the conflict (as below), and compiled with
"autoreconf -ivf ;./configure;make clean; make -j 4". The result is no
compile error. I am using gcc 4.8.2, too.

==========================================================
diff a/src/lib/src/Makefile.am b/src/lib/src/Makefile.am        (rejected hunks)
@@ -12,7 +12,7 @@ libfwts_la_LDFLAGS =                  \
        -L$(top_srcdir)/src/acpica/source/compiler \
        -lfwtsiasl

-libfwts_la_CPPFLAGS = $(AM_CPPFLAGS)
+libfwts_la_CPPFLAGS = $(AM_CPPFLAGS) -DACPI_DEBUG_OUTPUT

 #
 #  Components of the fwts core helper library libfwts
==========================================================

On Tue, May 6, 2014 at 4:51 PM, Colin Ian King <colin.king at canonical.com> wrote:
> On 06/05/14 09:47, IvanHu wrote:
>> On 05/06/2014 04:27 PM, Colin Ian King wrote:
>>> On 05/05/14 09:56, IvanHu wrote:
>>>> On 04/25/2014 02:26 AM, Colin King wrote:
>>>>> From: Colin Ian King<colin.king at canonical.com>
>>>>>
>>>>> For the specific ACPICA changes please refer to:
>>>>>
>>>>> https://lists.acpica.org/pipermail/devel/2014-April/000649.html
>>>>>
>>>>> The also adds a small shim wrapper in the fwts and fwtsiasl libraries
>>>>> to access ACPI compiler error levels because of some restructuring
>>>>> in ACPICA.
>>>>>
>>>>> This patchset also dismisses 14 issues as found by Coverity Scan.
>>>>>
>>>>> Signed-off-by: Colin Ian King<colin.king at canonical.com>
>>>>> ---
>>>>>    src/Makefile.am                                    |   2 +-
>>>>>    src/acpi/syntaxcheck/syntaxcheck.c                 |   5 +-
>>>>>    src/acpica/source/common/adisasm.c                 |   1 +
>>>>>    src/acpica/source/common/ahpredef.c                |   2 +
>>>>>    src/acpica/source/common/dmtable.c                 |  34 ++
>>>>>    src/acpica/source/common/dmtbdump.c                | 193 +++++---
>>>>>    src/acpica/source/common/dmtbinfo.c                |  57 +++
>>>>>    src/acpica/source/compiler/Makefile.am             |   1 +
>>>>>    src/acpica/source/compiler/aslanalyze.c            |  48 ++
>>>>>    src/acpica/source/compiler/aslcompiler.h           |  29 +-
>>>>>    src/acpica/source/compiler/aslerror.c              | 159 +++----
>>>>>    src/acpica/source/compiler/aslmessages.c           | 479
>>>>> +++++++++++++++++++
>>>>>    src/acpica/source/compiler/aslmessages.h           | 269 ++---------
>>>>>    src/acpica/source/compiler/aslmethod.c             |  23 +-
>>>>>    src/acpica/source/compiler/aslprepkg.c             |  12 +
>>>>>    src/acpica/source/compiler/asltypes.h              |   2 +-
>>>>>    src/acpica/source/compiler/dtcompiler.h            |  11 +-
>>>>>    src/acpica/source/compiler/dttable.c               |  83 +++-
>>>>>    src/acpica/source/compiler/dttemplate.h            |  27 ++
>>>>>    src/acpica/source/compiler/dtutils.c               |   7 +-
>>>>>    src/acpica/source/compiler/fwts_iasl_interface.c   |  18 +
>>>>>    src/acpica/source/compiler/fwts_iasl_interface.h   |   3 +
>>>>>    src/acpica/source/compiler/preprocess.h            |   2 +-
>>>>>    src/acpica/source/compiler/prutils.c               |   2 +-
>>>>>    src/acpica/source/components/debugger/dbcmds.c     |  27 +-
>>>>>    src/acpica/source/components/debugger/dbinput.c    |   4 +-
>>>>>    src/acpica/source/components/events/evgpe.c        |  12 +-
>>>>>    src/acpica/source/components/events/evgpeblk.c     |  28 +-
>>>>>    src/acpica/source/components/events/evgpeinit.c    |   8 +-
>>>>>    src/acpica/source/components/events/evxfgpe.c      |   3 +-
>>>>>    src/acpica/source/components/hardware/hwpci.c      |  13 +-
>>>>>    src/acpica/source/components/resources/rscreate.c  |  12 +-
>>>>>    src/acpica/source/components/tables/tbfadt.c       |  50 +-
>>>>>    src/acpica/source/components/tables/tbutils.c      | 123 +----
>>>>>    src/acpica/source/components/utilities/utglobal.c  |  30 +-
>>>>>    src/acpica/source/components/utilities/utobject.c  |   2 +-
>>>>>    src/acpica/source/components/utilities/utxferror.c |   4 +
>>>>>    src/acpica/source/include/acdisasm.h               |   8 +
>>>>>    src/acpica/source/include/acevents.h               |   5 +-
>>>>>    src/acpica/source/include/acglobal.h               | 143 +-----
>>>>>    src/acpica/source/include/aclocal.h                |   7 +-
>>>>>    src/acpica/source/include/acnames.h                |   1 +
>>>>>    src/acpica/source/include/acpixf.h                 | 518
>>>>> ++++++++++++++++-----
>>>>>    src/acpica/source/include/acpredef.h               |   4 +
>>>>>    src/acpica/source/include/actbl1.h                 |   4 +-
>>>>>    src/acpica/source/include/actbl2.h                 |  83 +++-
>>>>>    src/acpica/source/include/actypes.h                |  35 +-
>>>>>    src/acpica/source/include/platform/aclinux.h       |  33 ++
>>>>>    .../source/os_specific/service_layers/osunixxf.c   |  23 +-
>>>>>    src/acpica/source/tools/acpiexec/aehandlers.c      |   2 +-
>>>>>    src/lib/include/fwts_iasl.h                        |   3 +
>>>>>    src/lib/src/Makefile.am                            |   2 +-
>>>>>    src/lib/src/fwts_iasl.c                            |   4 +
>>>>>    53 files changed, 1799 insertions(+), 861 deletions(-)
>>>>>    create mode 100755 src/acpica/source/compiler/aslmessages.c
>>>>
>>>>
>>>> got build error!
>>>> please help to check. Thanks!
>>>>
>>>> /libfwtsacpica.so /usr/lib/x86_64-linux-gnu/libjson.so -Wl,-rpath
>>>> -Wl,/usr/local/lib/fwts
>>>> /home/ivanhu/work/fwts/src/lib/src/.libs/libfwts.so: undefined reference
>>>> to `fwts_iasl_exception_level__'
>>>> collect2: ld returned 1 exit status
>>>> make[3]: *** [fwts] Error 1
>>>> make[3]: Leaving directory `/home/work/fwts/src'
>>>> make[2]: *** [all-recursive] Error 1
>>>> make[2]: Leaving directory `/home/work/fwts/src'
>>>> make[1]: *** [all-recursive] Error 1
>>>> make[1]: Leaving directory `/home/work/fwts'
>>>> make: *** [all] Error 2
>>>>
>>>>
>>> I checked out a clean fwts and applied the patch and did:
>>>
>>> autoreconf -ivf
>>> ./configure
>>> make -j 4
>>>
>>> and it build fine on Trusty for me.  What release are you building it
>>> against?
>>>
>>> Colin
>>>
>>
>> I buidl on Trusty, gcc version 4.8.2
>>
>>
> Strange, me too. And it's on a clean install as of yesterday.  Do you
> mind re-doing the build with:
>
> script build.log
> autoreconf -ivf
> ./configure
> make clean
> make
> exit
>
> and see what happens and send me the build.log if it fails.
>
> Colin
>
>
> --
> fwts-devel mailing list
> fwts-devel at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel



-- 
Cheers,
Alex Hung



More information about the fwts-devel mailing list