ACK: [PATCH] uefi: uefirtvariable: explicitly ignore ioctl() return

Alex Hung alex.hung at canonical.com
Thu May 8 01:44:27 UTC 2014


On 05/08/2014 01:48 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> The code is deliberately ignoring the return from ioctl() but
> Coverity Scan is complaining about this.  Explicitly use (void)
> casts to indicate that we're really not interested in the ioctl
> return.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/uefi/uefirtvariable/uefirtvariable.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
> index 7ddfeb1..0933b95 100644
> --- a/src/uefi/uefirtvariable/uefirtvariable.c
> +++ b/src/uefi/uefirtvariable/uefirtvariable.c
> @@ -74,17 +74,17 @@ static void uefirtvariable_env_cleanup(void)
>   	setvariable.DataSize = 0;
>   	setvariable.Data = &data;
>   	setvariable.status = &status;
> -	ioctl(fd, EFI_RUNTIME_SET_VARIABLE, &setvariable);
> +	(void)ioctl(fd, EFI_RUNTIME_SET_VARIABLE, &setvariable);
>
>   	setvariable.VariableName = variablenametest2;
> -	ioctl(fd, EFI_RUNTIME_SET_VARIABLE, &setvariable);
> +	(void)ioctl(fd, EFI_RUNTIME_SET_VARIABLE, &setvariable);
>
>   	setvariable.VariableName = variablenametest3;
> -	ioctl(fd, EFI_RUNTIME_SET_VARIABLE, &setvariable);
> +	(void)ioctl(fd, EFI_RUNTIME_SET_VARIABLE, &setvariable);
>
>   	setvariable.VariableName = variablenametest;
>   	setvariable.VendorGuid = &gtestguid2;
> -	ioctl(fd, EFI_RUNTIME_SET_VARIABLE, &setvariable);
> +	(void)ioctl(fd, EFI_RUNTIME_SET_VARIABLE, &setvariable);
>   }
>
>   static int uefirtvariable_init(fwts_framework *fw)
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list