[RFC,PATCH 6/7 v2] fwts: Add FWTS_FW_FEATURE_DEVICETREE

Jeremy Kerr jk at ozlabs.org
Thu May 1 10:47:41 UTC 2014


Hi Colin,

>> --- a/src/lib/src/fwts_firmware.c
>> +++ b/src/lib/src/fwts_firmware.c
>> @@ -31,6 +31,7 @@ static struct {
>>  	const char name[16];
>>  } feature_names[] = {
>>  	{ FWTS_FW_FEATURE_ACPI,		"acpi" },
>> +	{ FWTS_FW_FEATURE_DEVICETREE,	"devicetree" },
>>  };
> 
> perhaps "Device Tree", "Device tree", "device tree"? I'm not sure what
> the standard name for this is.

That probably depends on what we want the convention for feature names
within fwts to be; I was going for single-work tokens here.

If we're going for the more human-readable two-word form, I don't think
we'd need to capitalise it, as it's not really a proper noun.

Cheers,


Jeremy




More information about the fwts-devel mailing list