ACK: [PATCH] fwts_hwinfo: don't compare network addresses (LP: #1293297)

Alex Hung alex.hung at canonical.com
Tue Mar 25 03:38:43 UTC 2014


On 03/17/2014 05:19 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> It seems that network addresses are valid to change over S4, so
> relax the test to not compare these anymore.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/src/fwts_hwinfo.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_hwinfo.c b/src/lib/src/fwts_hwinfo.c
> index 7c69444..3138485 100644
> --- a/src/lib/src/fwts_hwinfo.c
> +++ b/src/lib/src/fwts_hwinfo.c
> @@ -352,7 +352,6 @@ static int fwts_hwinfo_net_cmp(void *data1, void *data2)
>  	fwts_net_config *config2 = (fwts_net_config *)data2;
>  
>  	return strcmp(config1->name, config2->name) ||
> -	       strcmp(config1->addr, config2->addr) ||
>  	       strcmp(config1->hw_addr, config2->hw_addr);
>  }
>  
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list