NACK: [PATCH] fwts-test: arg-log-format-0001: update to sync with fwts

Colin Ian King colin.king at canonical.com
Fri Mar 7 09:10:56 UTC 2014


On 07/03/14 08:42, Ivan Hu wrote:
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  fwts-test/arg-log-format-0001/klog-0001.log |  550 +++++++++++++--------------
>  1 file changed, 275 insertions(+), 275 deletions(-)
> 
> diff --git a/fwts-test/arg-log-format-0001/klog-0001.log b/fwts-test/arg-log-format-0001/klog-0001.log
> index db134e0..6ce5b40 100644
> --- a/fwts-test/arg-log-format-0001/klog-0001.log
> +++ b/fwts-test/arg-log-format-0001/klog-0001.log
> @@ -1,275 +1,275 @@
> -klog            (00021) <10/02/14> HED  : klog: Scan kernel log for errors and
> -klog            (00022) <10/02/14> HED  : warnings.
> -klog            (00023) <10/02/14> SEP  : --------------------------------------
<text deleted>

NACK.

Unfortunately because the test is rather stupid one has to ensure the
date matches the original reference date hard coded in the test as this
is then replaced using sed to match the date one runs the test. It's
lame and I need to fix that. Until I fix that test, the klog-0001.log
date needs to be always <10/02/14>

..I can guarantee if you don't set the date the test will only work
today ;-)

Colin




More information about the fwts-devel mailing list