ACK: [PATCH 06/13] fwts-test: checksum-0001: update due to fwts formatting fixes
IvanHu
ivan.hu at canonical.com
Wed Mar 5 08:18:06 UTC 2014
On 03/05/2014 04:28 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> fwts checksum test now outputs checksums as 2 byte hex values, so
> update the tests to sync with this change.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> fwts-test/checksum-0001/checksum-0001.log | 34 +++++++++++++++----------------
> fwts-test/checksum-0001/checksum-0003.log | 32 ++++++++++++++---------------
> fwts-test/checksum-0001/checksum-0004.log | 4 ++--
> 3 files changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/fwts-test/checksum-0001/checksum-0001.log b/fwts-test/checksum-0001/checksum-0001.log
> index d720e06..8ce3148 100644
> --- a/fwts-test/checksum-0001/checksum-0001.log
> +++ b/fwts-test/checksum-0001/checksum-0001.log
> @@ -1,23 +1,23 @@
> checksum checksum: ACPI table checksum test.
> checksum --------------------------------------------------------------------------------------------------
> checksum Test 1 of 1: ACPI table checksum test.
> -checksum PASSED: Test 1, Table DSDT has correct checksum 0x11.
> -checksum PASSED: Test 1, Table FACP has correct checksum 0x52.
> -checksum PASSED: Test 1, Table APIC has correct checksum 0xcc.
> -checksum PASSED: Test 1, Table HPET has correct checksum 0xa.
> -checksum PASSED: Test 1, Table MCFG has correct checksum 0x32.
> -checksum PASSED: Test 1, Table TCPA has correct checksum 0x8f.
> -checksum PASSED: Test 1, Table TMOR has correct checksum 0xeb.
> -checksum PASSED: Test 1, Table SLIC has correct checksum 0x99.
> -checksum PASSED: Test 1, Table APIC has correct checksum 0x13.
> -checksum PASSED: Test 1, Table BOOT has correct checksum 0xa5.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0x59.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0xed.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0xc8.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0x6d.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0xdf.
> -checksum PASSED: Test 1, Table XSDT has correct checksum 0xc2.
> -checksum PASSED: Test 1, Table RSDT has correct checksum 0xd.
> +checksum PASSED: Test 1, Table DSDT has correct checksum 0x11
> +checksum PASSED: Test 1, Table FACP has correct checksum 0x52
> +checksum PASSED: Test 1, Table APIC has correct checksum 0xcc
> +checksum PASSED: Test 1, Table HPET has correct checksum 0x0a
> +checksum PASSED: Test 1, Table MCFG has correct checksum 0x32
> +checksum PASSED: Test 1, Table TCPA has correct checksum 0x8f
> +checksum PASSED: Test 1, Table TMOR has correct checksum 0xeb
> +checksum PASSED: Test 1, Table SLIC has correct checksum 0x99
> +checksum PASSED: Test 1, Table APIC has correct checksum 0x13
> +checksum PASSED: Test 1, Table BOOT has correct checksum 0xa5
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0x59
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0xed
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0xc8
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0x6d
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0xdf
> +checksum PASSED: Test 1, Table XSDT has correct checksum 0xc2
> +checksum PASSED: Test 1, Table RSDT has correct checksum 0x0d
> checksum
> checksum ==================================================================================================
> checksum 19 passed, 0 failed, 0 warning, 0 aborted, 0 skipped, 0 info only.
> diff --git a/fwts-test/checksum-0001/checksum-0003.log b/fwts-test/checksum-0001/checksum-0003.log
> index 4ab586a..4f2bf19 100644
> --- a/fwts-test/checksum-0001/checksum-0003.log
> +++ b/fwts-test/checksum-0001/checksum-0003.log
> @@ -8,22 +8,22 @@ checksum ADVICE: The kernel will warn that this table has an invalid chec
> checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> checksum messages.
> checksum
> -checksum PASSED: Test 1, Table FACP has correct checksum 0x52.
> -checksum PASSED: Test 1, Table APIC has correct checksum 0xcc.
> -checksum PASSED: Test 1, Table HPET has correct checksum 0xa.
> -checksum PASSED: Test 1, Table MCFG has correct checksum 0x32.
> -checksum PASSED: Test 1, Table TCPA has correct checksum 0x8f.
> -checksum PASSED: Test 1, Table TMOR has correct checksum 0xeb.
> -checksum PASSED: Test 1, Table SLIC has correct checksum 0x99.
> -checksum PASSED: Test 1, Table APIC has correct checksum 0x13.
> -checksum PASSED: Test 1, Table BOOT has correct checksum 0xa5.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0x59.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0xed.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0xc8.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0x6d.
> -checksum PASSED: Test 1, Table SSDT has correct checksum 0xdf.
> -checksum PASSED: Test 1, Table XSDT has correct checksum 0xc2.
> -checksum PASSED: Test 1, Table RSDT has correct checksum 0xd.
> +checksum PASSED: Test 1, Table FACP has correct checksum 0x52
> +checksum PASSED: Test 1, Table APIC has correct checksum 0xcc
> +checksum PASSED: Test 1, Table HPET has correct checksum 0x0a
> +checksum PASSED: Test 1, Table MCFG has correct checksum 0x32
> +checksum PASSED: Test 1, Table TCPA has correct checksum 0x8f
> +checksum PASSED: Test 1, Table TMOR has correct checksum 0xeb
> +checksum PASSED: Test 1, Table SLIC has correct checksum 0x99
> +checksum PASSED: Test 1, Table APIC has correct checksum 0x13
> +checksum PASSED: Test 1, Table BOOT has correct checksum 0xa5
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0x59
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0xed
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0xc8
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0x6d
> +checksum PASSED: Test 1, Table SSDT has correct checksum 0xdf
> +checksum PASSED: Test 1, Table XSDT has correct checksum 0xc2
> +checksum PASSED: Test 1, Table RSDT has correct checksum 0x0d
> checksum
> checksum ==================================================================================================
> checksum 18 passed, 1 failed, 0 warning, 0 aborted, 0 skipped, 0 info only.
> diff --git a/fwts-test/checksum-0001/checksum-0004.log b/fwts-test/checksum-0001/checksum-0004.log
> index f69a42a..cfc576d 100644
> --- a/fwts-test/checksum-0001/checksum-0004.log
> +++ b/fwts-test/checksum-0001/checksum-0004.log
> @@ -1,7 +1,7 @@
> checksum checksum: ACPI table checksum test.
> checksum --------------------------------------------------------------------------------------------------
> checksum Test 1 of 1: ACPI table checksum test.
> -checksum PASSED: Test 1, Table DSDT has correct checksum 0x11.
> +checksum PASSED: Test 1, Table DSDT has correct checksum 0x11
> checksum FAILED [MEDIUM] ACPITableChecksum: Test 1, Table FACP has incorrect checksum, expected 0x52, got
> checksum 0x53.
> checksum
> @@ -107,7 +107,7 @@ checksum ADVICE: The kernel will warn that this table has an invalid chec
> checksum still load it. This is not a critical issue, but should be fixed if possible to avoid the warning
> checksum messages.
> checksum
> -checksum PASSED: Test 1, Table RSDT has correct checksum 0xd.
> +checksum PASSED: Test 1, Table RSDT has correct checksum 0x0d
> checksum
> checksum ==================================================================================================
> checksum 4 passed, 15 failed, 0 warning, 0 aborted, 0 skipped, 0 info only.
>
Acked-by: Ivan Hu <ivan.hu at canonical.com>
More information about the fwts-devel
mailing list