ACK: [PATCH 06/12] acpi: method: re-arrange code to avoid declarations after code

Alex Hung alex.hung at canonical.com
Tue Jun 10 17:48:09 UTC 2014


On 06/08/2014 09:42 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Another mixed declarations and code fix
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/method/method.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 4324b2d..bb2c12d 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -2594,9 +2594,9 @@ static void method_test_CST_return(
>  
>  	/* Could be one or more packages */
>  	for (i = 1; i < obj->Package.Count; i++) {
> -		cst_elements_ok[i] = true;
> -
>  		ACPI_OBJECT *pkg;
> +
> +		cst_elements_ok[i] = true;
>  		if (obj->Package.Elements[i].Type != ACPI_TYPE_PACKAGE) {
>  			fwts_failed(fw, LOG_LEVEL_MEDIUM,
>  				"Method_CSTElementType",
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list