[PATCH 01/12] src/lib/*.h: remove extraneous , at end of enum lists

Colin Ian King colin.king at canonical.com
Mon Jun 9 13:33:20 UTC 2014


On 09/06/14 14:27, Jeremy Kerr wrote:
> Hi Colin,
> 
>> The trailing , is extraneous in enums, so remove it.
> 
> Why though? This means that any patch that subsequently adds an enum
> member has to modify the last item, rather than just adding a line.

Style more than anything else:

1. it was not being used consistently, so I wanted some form of style to
be used across fwts, so I aligned it with what ACPICA is using.
2. it's less warning noise when I add in some very pedantic flags with
various compilers I test fwts builds with
3. i like being anal.

Colin

> 
> Cheers,
> 
> 
> Jeremy
> 




More information about the fwts-devel mailing list