ACK: [PATCH] ACPI: Add new ACPI 5.1 FADT fields and update acpidump (LP: #1348598)

[Alex Hung]

On 07/25/2014 07:31 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Replace reserved field with the new ACPI 5.1 ARM boot flag field and a
> FADT minor version field
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/acpidump/acpidump.c | 6 +++++-
>  src/lib/include/fwts_acpi.h  | 3 ++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c
> index 15a4e5d..02a0d23 100644
> --- a/src/acpi/acpidump/acpidump.c
> +++ b/src/acpi/acpidump/acpidump.c
> @@ -668,7 +668,11 @@ static void acpidump_fadt(fwts_framework *fw, const fwts_acpi_table_info *table)
>  		FIELD_BITF("  Use APIC Physical Dest. Mode (V4)", 	fwts_acpi_table_fadt, flags, 1, 19),
>  		FIELD_BITF("  ACPI hardware is not implemented (V5)",	fwts_acpi_table_fadt, flags, 1, 20),
>  		FIELD_BITF("  S0 power savings are equal or better than S3 (V5)", fwts_acpi_table_fadt, flags, 1, 21),
> -		FIELD_BITF("  RESERVED", 				fwts_acpi_table_fadt, flags, 10, 22),
> +		FIELD_BITF("  Reserved (bits 22..31)",			fwts_acpi_table_fadt, flags, 10, 22),
> +		FIELD_UINT("ARM Boot Flags (V5.1)",			fwts_acpi_table_fadt, arm_boot_flags),
> +		FIELD_BITF("  PSCI Compliant (V5.1)",			fwts_acpi_table_fadt, arm_boot_flags, 1, 0),
> +		FIELD_BITF("  PSCI Use HSC instead of SMC (V5.1)",	fwts_acpi_table_fadt, arm_boot_flags, 1, 1),
> +		FIELD_UINT("FADT Minor Version",			fwts_acpi_table_fadt, minor_version),
>  		FIELD_GAS ("RESET_REG", 				fwts_acpi_table_fadt, reset_reg),
>  		FIELD_UINT("RESET_VALUE", 				fwts_acpi_table_fadt, reset_value),
>  		FIELD_UINT("X_FIRMWARE_CTRL", 				fwts_acpi_table_fadt, x_firmware_ctrl),
> diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h
> index ceb6507..de7a889 100644
> --- a/src/lib/include/fwts_acpi.h
> +++ b/src/lib/include/fwts_acpi.h
> @@ -198,7 +198,8 @@ typedef struct {
>  	uint32_t	flags;
>  	fwts_acpi_gas	reset_reg;
>  	uint8_t		reset_value;
> -	uint8_t		reserved2[3];
> +	uint16_t	arm_boot_flags;
> +	uint8_t		minor_version;
>  	uint64_t	x_firmware_ctrl;
>  	uint64_t	x_dsdt;
>  	fwts_acpi_gas	x_pm1a_evt_blk;
> 

Acked-by: Alex Hung <alex.hung at canonical.com>

-- 
Cheers,
Alex Hung