[PATCH 0/2] re-work iASL backend

Colin Ian King colin.king at canonical.com
Fri Jul 25 12:56:09 UTC 2014


This extensive fix which took a lot of engineering effort to get working
correctly has been sitting here since *May*.  Can it be applied some
time real soon as I'd like to continue working on this code area.

Actually, some urgency on any patches sent to this list has been lacking
of late. I realize code review and applying patches is time consuming,
but it's also a waste of effort if these patches get reviewed and never
applied.

Thanks!

Colin

On 29/05/14 14:59, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Currently the iASL interface is not handling extern declarations
> at all, which is leading to false positives on test such as the
> syntaxcheck test.  This patchset re-works the interface to the
> ACPICA assembler/disassembler to allow one to pass over all the
> tables containing AML so that exernal objects can be resolved
> correctly.  The patchset includes a re-working of the fwts
> iasl interface and modifications to the tests that use these.
> 
> The iasl interface includes some caching of dumped DSDT and SSDT
> tables, hence the new requirement for a init/deinit phase before using
> the assembler/disassembler to load and destroy these cached
> tables.
> 
> Colin Ian King (2):
>   lib + tests: re-work iASL backand and API to handle externals (LP:
>     #1317390)
>   fwts-test: fix up tests related to iasl and syntaxcheck changes
> 
>  .../arg-show-tests-0001/arg-show-tests-0001.log    |    2 +-
>  .../arg-show-tests-full-0001.log                   |    7 +-
>  fwts-test/disassemble-0001/DSDT.dsl.original       | 6636 --------------------
>  fwts-test/disassemble-0001/DSDT0.dsl.original      | 6636 ++++++++++++++++++++
>  fwts-test/disassemble-0001/SSDT0.dsl.original      |  156 -
>  fwts-test/disassemble-0001/SSDT1.dsl.original      |  157 +-
>  fwts-test/disassemble-0001/SSDT2.dsl.original      |  286 +-
>  fwts-test/disassemble-0001/SSDT3.dsl.original      |  248 +-
>  fwts-test/disassemble-0001/SSDT4.dsl.original      |  219 +-
>  fwts-test/disassemble-0001/SSDT5.dsl.original      |  216 +
>  .../disassemble-0001/disassemble-aml-0001.log      |   12 +-
>  fwts-test/disassemble-0001/test-0001.sh            |   12 +-
>  fwts-test/syntaxcheck-0001/syntaxcheck-0001.log    |   84 +-
>  src/acpi/osilinux/osilinux.c                       |    7 +
>  src/acpi/syntaxcheck/syntaxcheck.c                 |   46 +-
>  src/acpica/source/compiler/fwts_iasl_interface.c   |   31 +-
>  src/acpica/source/compiler/fwts_iasl_interface.h   |    2 +-
>  src/hpet/hpet_check/hpet_check.c                   |   14 +-
>  src/lib/include/fwts_iasl.h                        |    8 +-
>  src/lib/src/fwts_iasl.c                            |  232 +-
>  20 files changed, 7576 insertions(+), 7435 deletions(-)
>  delete mode 100644 fwts-test/disassemble-0001/DSDT.dsl.original
>  create mode 100644 fwts-test/disassemble-0001/DSDT0.dsl.original
>  delete mode 100644 fwts-test/disassemble-0001/SSDT0.dsl.original
>  create mode 100644 fwts-test/disassemble-0001/SSDT5.dsl.original
> 




More information about the fwts-devel mailing list