ACK: [PATCH 04/10] acpi: s3: fix shadowing of variable 'i'
Alex Hung
alex.hung at canonical.com
Fri Jul 11 07:46:03 UTC 2014
On 06/13/2014 02:03 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> variable 'i' was being shadowed, so rename the inner scoped
> one to j just to avoid any confusion
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> src/acpi/s3/s3.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
> index e5b6ef1..89758fc 100644
> --- a/src/acpi/s3/s3.c
> +++ b/src/acpi/s3/s3.c
> @@ -343,14 +343,15 @@ static int s3_test_multiple(fwts_framework *fw)
>
> if (!s3_device_check) {
> char buffer[80];
> - int i;
> + int j;
>
> tv.tv_sec = 0;
> tv.tv_usec = (awake_delay % 1000)*1000;
> select(0, NULL, NULL, NULL, &tv);
>
> - for (i=0; i<awake_delay/1000; i++) {
> - snprintf(buffer, sizeof(buffer), "(Waiting %d/%d seconds)", i+1, awake_delay/1000);
> + for (j = 0; j < awake_delay / 1000; i++) {
> + snprintf(buffer, sizeof(buffer), "(Waiting %d/%d seconds)",
> + j + 1, awake_delay / 1000);
> fwts_progress_message(fw, percent, buffer);
> sleep(1);
> }
>
Acked-by: Alex Hung <alex.hung at canonical.com>
More information about the fwts-devel
mailing list