ACK: [PATCH] Allow for RSDP that is not 16 byte aligned (LP: #1271522)

IvanHu ivan.hu at canonical.com
Thu Jan 23 05:28:17 UTC 2014


On 01/22/2014 08:24 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Commit 94ea2aa606a8115325e5c5781a958c4eb9ce856b presumed that the
> RSDP is 16 byte aligned. However, UEFI systems don't seem to apply
> to this old BIOS rule of thumb, so relax this constraint.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index b226e51..ca3b34a 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -295,10 +295,6 @@ static int fwts_acpi_load_tables_from_firmware(fwts_framework *fw)
>   	if (!rsdp_addr)
>   		return FWTS_ERROR;
>
> -	/* Must be on a 16 byte boundary */
> -	if (((unsigned long)rsdp_addr & 0xf))
> -		return FWTS_ERROR;
> -
>   	/* Load and save cached RSDP */
>   	if ((rsdp = fwts_acpi_get_rsdp(rsdp_addr, &rsdp_len)) == NULL)
>   		return FWTS_ERROR;
>

Acked-by: Ivan Hu <ivan.hu at canonical.com>




More information about the fwts-devel mailing list