ACK: [PATCH] uefibootpath: uefibootpath_check_dev_path: return int rather than int *

ivanhu ivan.hu at canonical.com
Fri Dec 5 09:02:58 UTC 2014


On 2014年11月27日 20:08, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> compiling with clang:
> uefi/uefibootpath/uefibootpath.c:693:9: error: expression which evaluates
>    to zero treated as a null pointer constant of type 'int *'
>    [-Werror,-Wnon-literal-null-conversion]
>          return FWTS_OK;
>                 ^~~~~~~
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/uefi/uefibootpath/uefibootpath.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefibootpath/uefibootpath.c b/src/uefi/uefibootpath/uefibootpath.c
> index 007aa0f..46c2455 100644
> --- a/src/uefi/uefibootpath/uefibootpath.c
> +++ b/src/uefi/uefibootpath/uefibootpath.c
> @@ -41,7 +41,7 @@ static int uefibootpath_init(fwts_framework *fw)
>   	return FWTS_OK;
>   }
>   
> -static int *uefibootpath_check_dev_path(fwts_framework *fw, fwts_uefi_dev_path *dev_path, const size_t dev_path_len)
> +static int uefibootpath_check_dev_path(fwts_framework *fw, fwts_uefi_dev_path *dev_path, const size_t dev_path_len)
>   {
>   	uint16_t len;
>   
Thanks! Colin,

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list