[PATCH] data: klog.json: re-work _S1 and _S2 advice

[Colin Ian King]

On 28/04/14 04:30, Alex Hung wrote:
> On 04/26/2014 06:34 PM, Colin King wrote:
>> From: Colin Ian King <colin.king at canonical.com>
>>
>> Minor re-working of the _S1 and _S2 advice messages.
>>
>> Signed-off-by: Colin Ian King <colin.king at canonical.com>
>> ---
>>   data/klog.json | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/data/klog.json b/data/klog.json
>> index 82673e4..1c3c47f 100644
>> --- a/data/klog.json
>> +++ b/data/klog.json
>> @@ -1069,14 +1069,14 @@
>>       "compare_mode": "string",
>>       "log_level": "LOG_LEVEL_INFO",
>>       "pattern": "While evaluating Sleep State [\\_S1_]",
>> -    "advice": "The exception comes from kernel cannot find _S1
>> namespace object that contains the register values for the sleep state
>> when kernel would like to setup all the sleep state information. This
>> means kernel don't know how to enter S1 sleep state. But it should not
>> be a problem if the S1 sleep state isn't supported intentionally.",
>> +    "advice": "The exception comes from kernel cannot find _S1
>> namespace object that contains the register values for the sleep state
>> when kernel would like to setup all the sleep state information. This
>> means that the kernel does not know how to enter the S1 sleep state,
>> however, it should not be a problem if the S1 sleep state isn't
>> supported intentionally.",
>>       "label": "KlogAcpiSleepStateEvalFailed"
>>     },
>>     {
>>       "compare_mode": "string",
>>       "log_level": "LOG_LEVEL_INFO",
>>       "pattern": "While evaluating Sleep State [\\_S2_]",
>> -    "advice": "The exception comes from kernel cannot find _S2
>> namespace object that contains the register values for the sleep state
>> when kernel would like to setup all the sleep state information. This
>> means kernel don't know how to enter S2 sleep state. But it should not
>> be a problem if the S2 sleep state isn't supported intentionally.",
>> +    "advice": "The exception comes from kernel cannot find _S2
>> namespace object that contains the register values for the sleep state
>> when kernel would like to setup all the sleep state information. This
>> means that the kernel does not know how to enter the S2 sleep state,
>> however, it should not be a problem if the S2 sleep state isn't
>> supported intentionally.",
>>       "label": "KlogAcpiSleepStateEvalFailed"
>>     },
>>     {
>>
> 
> I saw the same errors for S3 and S4 on servers which does not support
> them. Unfortunately we cannot make the same changes for S3 and S4. I
> wonder when this will be fixed in Linux kernel (I sent a patch but it is
> ignored :().
> 
I'd re-send the patch, it should get some attention.

Colin