[RFC,PATCH 0/4] Introduce firmware features

[Colin Ian King]

On 24/04/14 09:18, Jeremy Kerr wrote:
> I've been playing with FWTS on a non-ACPI machine, and got a lot of
> aborts due to there not being various ACPI-specific bits of
> functionality present.
> 
> It seems appropriate to define a new type for this firmware, but I don't
> want to add type checks all over the existing fwts tests.
> 
> Rather than checking the type of firmware (and only running ACPI tests
> when we know that the firmware is of type UEFI or BIOS), I'd like to use
> more-flexible features instead; this way, each test can check if
> required features are available, rather than assuming that $type
> firmware has $feature_set.
> 
> Currently, we just key the feature set off the firmware type, but we
> could do something more flexible in future. I've only defined an ACPI
> feature for now.
> 
> Patch 3 is a basic usage of these features; we skip the batch tests that
> require ACPI if the firmware doesn't have the FWTS_FW_FEATURE_ACPI
> feature.
> 
> This is just an RFC at the moment - please let me know if there's a
> better approach. We could also add the required feature bits to the test
> definition, rather than performing a check in the .init callback.
> 
> Cheers,
> 
This is a great starting point. No real major quibbles, see my notes in
patch 3/4 for a more generic solution rather than modifying every test
with a check and skip.


> 
> Jeremy
> 
> ---
> Jeremy Kerr (4):
>       fwts: Add fwts_firmware_has_feature
>       fwts: Only run firmware detection once
>       acpi: only run ACPI tests if we have ACPI
>       fwts: Add OPAL firmware type
> 
>