ACK: [PATCH] uefi: Don't abort on non-UEFI firmware

[Colin Ian King]

On 24/04/14 08:41, Jeremy Kerr wrote:
> Hi all,
> 
>>> @@ -321,7 +321,7 @@ static int securebootcert_init(fwts_framework *fw)
>>>  {
>>>  	if (fwts_firmware_detect() != FWTS_FIRMWARE_UEFI) {
>>>  		fwts_log_info(fw, "Cannot detect any UEFI firmware. Aborted.");
>>> -		return FWTS_ABORTED;
>>> +		return FWTS_SKIP;
>>>  	}
>>>  
>>>  	if (!fwts_uefi_efivars_iface_exist()) {
> 
> Just so I get this right in future - what's the conceptual difference
> between a skip and an abort? Abort looked like more of a failure to me,
> hence the change. But is there a more solid definition here?

Abort was to stop further sub-tests from running, it's like a hard stop
for subsequent sub-tests.  For example, if you run a test that requires
a specific resource common in all the sub-tests.  A SKIP is just a
notional concept to skip over a test because something can't be tested
and it registered as "can't test it, not a pass and not a fail"

> 
> Thanks!
> 
> 
> Jeremy
>