ACK: [PATCH] acpi: method: add _PIC control method tests (LP: #1255890)
Colin Ian King
colin.king at canonical.com
Thu Nov 28 10:31:32 UTC 2013
On 28/11/13 09:38, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
> src/acpi/method/method.c | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index e06992c..e347378 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -143,7 +143,7 @@
> * _PCT 8.4.4.1 Y
> * _PDC 8.4.1 N
> * _PDL 8.4.4.6 Y
> - * _PIC 5.8.1 N
> + * _PIC 5.8.1 Y
> * _PIF 10.3.3 Y
> * _PLD 6.1.8 Y
> * _PMC 10.4.1 N
> @@ -880,6 +880,24 @@ static int method_test_AEI(fwts_framework *fw)
> }
>
> /*
> + * Section 5.8 System Configuration Objects
> + */
> +static int method_test_PIC(fwts_framework *fw)
> +{
> + ACPI_OBJECT arg[1];
> + int i;
> +
> + arg[0].Type = ACPI_TYPE_INTEGER;
> + for (i = 0; i < 3; i++) {
> + arg[0].Integer.Value = i;
> + method_evaluate_method(fw, METHOD_OPTIONAL,
> + "_PIC", arg, 1, method_test_NULL_return, NULL);
> + }
> +
> + return FWTS_OK;
> +}
> +
> +/*
> * Section 6.1 Device Identification Objects
> */
> static int method_test_DDN(fwts_framework *fw)
> @@ -4864,7 +4882,7 @@ static fwts_framework_minor_test method_tests[] = {
> /* { method_test_REV, "Test _REV (Revision)." }, */
>
> /* Section 5.8 System Configuration Objects */
> - /* { method_test_PIC, "Test _PIC (Inform AML of Interrupt Model)." }, */
> + { method_test_PIC, "Test _PIC (Inform AML of Interrupt Model)." },
>
> /* Section 6.1 Device Identification Objects */
>
>
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the fwts-devel
mailing list