[PATCH 0/2] don't use external utils for H/W checks (LP: #1246646)

Colin King colin.king at canonical.com
Thu Nov 7 19:33:39 UTC 2013


From: Colin Ian King <colin.king at canonical.com>

The bug LP#1246646 requested we removed lspci. I've re-worked the code
to in fact remove all dependencies on external utilities to do the
H/W configuration checking between S3 and S4 cycles.

The fix included:

1. Adding a PCI helper to help describe a PCI device
2. Re-working fwts_hwinfo to strip out the reliance on external utilities

The result is that we can now easily see what has changed rather than just
being notified that something has changed which was a big weakness in the
old code.

Colin Ian King (2):
  lib: Add PCI helper to return description of a device
  lib: fwts_hwinfo: don't use external utils for H/W checks (LP:
    #1246646)

 src/lib/include/fwts_hwinfo.h |  13 +-
 src/lib/include/fwts_pci.h    |   2 +
 src/lib/src/Makefile.am       |   1 +
 src/lib/src/fwts_hwinfo.c     | 672 ++++++++++++++++++++++++++++++++++++------
 src/lib/src/fwts_pci.c        | 154 ++++++++++
 5 files changed, 738 insertions(+), 104 deletions(-)
 create mode 100644 src/lib/src/fwts_pci.c

-- 
1.8.3.2




More information about the fwts-devel mailing list