ACK: [PATCH] dmi: dmi_decode: Add checks for frequent bad defaults on AMI firmware

[Alex Hung]

It's too bad that system vendors hardly pay attention on DMI data.

I still remember a senior BIOS manager told me "I don't know why DMI are
still around still it is close to no use.". This is just sad.

Acked-by: Alex <alex.hung at canonical.com>


On Wed, May 29, 2013 at 11:09 PM, Colin King <colin.king at canonical.com>wrote:

> From: Colin Ian King <colin.king at canonical.com>
>
> Add checks for some common bad default strings that are see on a
> range of AMI firmware.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/dmi/dmi_decode/dmi_decode.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/dmi/dmi_decode/dmi_decode.c
> b/src/dmi/dmi_decode/dmi_decode.c
> index d89ab28..acdf333 100644
> --- a/src/dmi/dmi_decode/dmi_decode.c
> +++ b/src/dmi/dmi_decode/dmi_decode.c
> @@ -87,7 +87,13 @@ typedef struct {
>  static const fwts_dmi_pattern dmi_patterns[] = {
>         { "DMISerialNumber",    "Serial Number",        "0123456789" },
>         { "DMISerialNumber",    "Serial Number",        "System Serial
> Number" },
> +       { "DMISerialNumber",    "Serial Number",        "MB-1234567890" },
> +       { "DMISerialNumber",    NULL,                   "Chassis Serial
> Number" },
>         { "DMIAssetTag",        "Asset Tag",            "1234567890" },
> +       { "DMIAssetTag",        "Asset Tag",            "Asset-1234567890"
> },
> +       { "DMIChassisVendor",   NULL,                   "Chassis
> Manufacture" },
> +       { "DMIChassisVersion",  NULL,                   "Chassis Version"
> },
> +       { "DMIProductVersion",  NULL,                   "System Version" },
>         { "DMIBadDefault",      NULL,                   "To Be Filled By
> O.E.M." },
>         { NULL,                 NULL,                   NULL }
>  };
> --
> 1.8.1.2
>
>
> --
> fwts-devel mailing list
> fwts-devel at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/fwts-devel
>



-- 
Cheers,
Alex Hung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20130530/ef234fdd/attachment-0001.html>