[PATCH] acpi: fan: fix resource leak bugs

IvanHu ivan.hu at canonical.com
Thu May 16 02:19:59 UTC 2013


On 05/07/2013 06:42 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Coverity CID #997266, #997267 Resource leak.
>
> close opened dir and free info on error return.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpi/fan/fan.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/acpi/fan/fan.c b/src/acpi/fan/fan.c
> index 586ec50..184da1a 100644
> --- a/src/acpi/fan/fan.c
> +++ b/src/acpi/fan/fan.c
> @@ -76,12 +76,15 @@ static fwts_list *get_fan_info(fwts_framework *fw)
>   			if (info == NULL) {
>   				fwts_log_error(fw, "Out of memory gathing fan information.");
>   				fwts_list_free(fans, free_fan_info);
> +				closedir(dir);
>   				return NULL;
>   			}
>
>   			if ((info->name = strdup(entry->d_name)) == NULL) {
>   				fwts_log_error(fw, "Out of memory gathing fan information.");
>   				fwts_list_free(fans, free_fan_info);
> +				free(info);
> +				closedir(dir);
>   				return NULL;
>   			}
>
>

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list