[PATCH] cpu: maxfreq: fix leak of cpuinfo

Keng-Yu Lin kengyu at canonical.com
Thu May 9 06:37:27 UTC 2013


On Tue, May 7, 2013 at 5:38 AM, Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Coverity CID #997351, Resource leak.
>
> Need to free cpuinfo before we return.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/cpu/maxfreq/maxfreq.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/cpu/maxfreq/maxfreq.c b/src/cpu/maxfreq/maxfreq.c
> index 87df364..b6fa38c 100644
> --- a/src/cpu/maxfreq/maxfreq.c
> +++ b/src/cpu/maxfreq/maxfreq.c
> @@ -81,6 +81,7 @@ static int maxfreq_test1(fwts_framework *fw)
>
>         if ((cpufreq = calloc(cpus, sizeof(double))) == NULL) {
>                 fwts_log_error(fw, "Cannot create cpu frequency array.");
> +               fwts_list_free(cpuinfo, free);
>                 return FWTS_ERROR;
>         }
>
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>



More information about the fwts-devel mailing list