ACK: [PATCH] uefi: uefidump: fix missing break in switch statement

Alex Hung alex.hung at canonical.com
Thu May 9 06:21:30 UTC 2013


On 05/07/2013 07:49 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Coverity CID #997290, Missing break in switch
>
> We are missing a break causing and unintentional fall-through to
> an Unknown-ACPI-DEV-PATH default.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/uefi/uefidump/uefidump.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index b115a62..771f904 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -168,6 +168,7 @@ static char *uefidump_build_dev_path(char *path, fwts_uefi_dev_path *dev_path)
>   				else
>   					path = uefidump_vprintf(path, "%s,", hidstr);
>   			}
> +			break;
>   		default:
>   			path = uefidump_vprintf(path, "\\Unknown-ACPI-DEV-PATH(0x%" PRIx8 ")", dev_path->subtype);
>   			break;
>
Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list