ACK: [PATCH] acpica: fwts_acpica: clear sa_mask fields

Alex Hung alex.hung at canonical.com
Wed May 8 02:11:45 UTC 2013


On 05/07/2013 03:21 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Coverity CID #997325, Uninitialized scalar variable (UNINIT)
>
> We should also clear the sa_mask fields.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/acpica/fwts_acpica.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index b9c8839..85ac735 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -585,6 +585,7 @@ ACPI_STATUS AcpiOsWaitSemaphore(ACPI_HANDLE handle, UINT32 Units, UINT16 Timeout
>   		 *  control to continue.  It is evil.
>   		 */
>   		sa.sa_handler = sem_alarm;
> +		sigemptyset(&sa.sa_mask);
>   		sa.sa_flags = 0;
>   		sigaction(SIGALRM, &sa, NULL);
>   		alarm(MAX_WAIT_TIMEOUT);
>
Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list