[PATCH] lib: fwts_memorymap: free klog on error

Colin King colin.king at canonical.com
Mon May 6 21:53:39 UTC 2013


From: Colin Ian King <colin.king at canonical.com>

Coverity CID #997341, Resource leak.

Need to free klog list before we return.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/lib/src/fwts_memorymap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c
index 2988e5b..6e8bc1e 100644
--- a/src/lib/src/fwts_memorymap.c
+++ b/src/lib/src/fwts_memorymap.c
@@ -233,8 +233,10 @@ fwts_list *fwts_memory_map_table_load_from_klog(fwts_framework *fw)
 	if ((klog = fwts_klog_read()) == NULL)
 		return NULL;
 
-	if ((memory_map_list = fwts_list_new()) == NULL)
+	if ((memory_map_list = fwts_list_new()) == NULL) {
+		fwts_klog_free(klog);
 		return NULL;
+	}
 
 	fwts_list_iterate(klog, fwts_memory_map_dmesg_info, memory_map_list);
 	fwts_klog_free(klog);
-- 
1.8.1.2




More information about the fwts-devel mailing list