[PATCH 0/2] dmi: merge dmi_decode and smbios tests to dmicheck

[Alex Hung]

On 07/02/2013 02:41 PM, Colin Ian King wrote:
> On 02/07/13 07:06, Alex Hung wrote:
>> FWTS has two tests related to smbios - dmi_decode and smbios as below:
>> 1. dmi_decode - Test DMI/SMBIOS tables for errors.
>> 2. smbios - Find and Check SMBIOS Table Entry Point.
>>
>> The patches merge them into a single "dmicheck" test.
>>
>> Buglink: launchpad.net/bugs/1196779
>>
>> Alex Hung (2):
>>    dmi: dmi_decode: merge smbios test as they both check dmi/smbios
>>    dmi: rename dmi_decode test to dmicheck
>>
>>   src/Makefile.am                 |    3 +-
>>   src/bios/smbios/smbios.c        |  225 ------
>>   src/dmi/dmi_decode/dmi_decode.c | 1304 ----------------------------------
>>   src/dmi/dmicheck/dmicheck.c     | 1492 +++++++++++++++++++++++++++++++++++++++
>>   4 files changed, 1493 insertions(+), 1531 deletions(-)
>>   delete mode 100644 src/bios/smbios/smbios.c
>>   delete mode 100644 src/dmi/dmi_decode/dmi_decode.c
>>   create mode 100644 src/dmi/dmicheck/dmicheck.c
>>
>
> Conceptually OK, however, the order of the code in the resulting merge
> is confusing to me.  Test #1 should probably be before test #2. That
> includes the helper functions to test #1 too, so the order is something
> like:
>
> smbios_dump_entry
> smbios_dmi_sane
> dmicheck_test1
> ..
>
> then test 2 code..
>
> dmi_used_by_kernel
> dmi_remap_version
> ..
> ..
> dmicheck_test2
>
>
> and since the smbios test has been renamed, we should probably also
> rename the smbios_* tests to something like:
>
> smbios_dump_entry --> dmi_dump_entry
> smbios_dmi_sane --> dmi_sane


I revised the patches to v2 and sent it just a few minutes ago. :)

>
> Finally, this renaming will break fwts-test, so this needs changing.
> And I think we ultimately need to note that the original tests are
> deprecated and now merged into dmicheck - so the fwts wiki needs
> updating referencing the changes with respect to the version number so
> that users don't get confused about which tests exist in which
> particular version of fwts.

Thanks for reminding. I will work on them as well.

>
> Thanks!
>
> Colin
>


-- 
Cheers,
Alex Hung