ACK: [PATCH] data: klog.json: Make FADT truncated warning into info message

[Colin Ian King]

On 29/01/13 06:39, Ivan Hu wrote:
> Most platforms which firmware support ACPI 5.0 FADT, however the precise kernel
> does not support ACPI version 5.0. the pre version 5.0 kernels will truncate the
>   FADT back to ACPI 2.0 size and ignore the extra ACPI 5.0 settings.
>
> fwts klog scanner will report it as high failure:
>   klog: HIGH Kernel message: [    0.000000] ACPI Warning: FADT (revision 5) is longer than ACPI 2.0 version, truncating length 268 to 244 (20110623/tbfadt-288)
>
> This failure was detected in bug report LP#1055591, LP#1061710, LP#1050679
>
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>   data/klog.json |    8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index e00f285..1694806 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3012,6 +3012,14 @@
>     },
>     {
>      "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_INFO",
> +   "tag": "FWTS_TAG_ACPI_BAD_LENGTH",
> +   "pattern": "ACPI Warning.*FADT .*revision 5.* is longer than ACPI 2.*0 version",
> +   "advice": "The kernel has not supported ACPI version 5.0, it truncated the FADT back to ACPI2.0 size and ignored the extra ACPI5.0 settings.",
> +   "label": "KlogAcpiFadtTruncatedLength"
> +  },
> +  {
> +   "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_THROTTLING",
>      "pattern": "ACPI Warning.*Invalid throttling state",
>
Good idea.

Acked-by: Colin Ian King <colin.king at canonical.com>