ACK: [PATCH] data: klog.json: add better advice for a common firmware issue

[Alex Hung]

On 01/25/2013 06:52 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> This adds better advice for a common firmware issue found with _SRS
> controls, for example in Bug LP:#1076979
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   data/klog.json | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 24ebd09..e78a203 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2766,6 +2766,14 @@
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
> +   "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*_SRS.*AE_AML_BUFFER_LIMIT",
> +   "advice": "Method failed: ResourceSourceIndex is present but ResourceSource is not. This is a common issue from a particular BIOS vendor, the _SRS (Set Resource Settings) optional control takes a byte stream argument that specifies a new resource allocation for a device. The resource descriptors in the byte stream argument must be specified exactly as listed by _CRS.  However, in this case _SRS has been passed a byte stream that is too short and attempted to access bytes outside the buffer causing this error. This is a firmware bug that needs to be fixed.",
> +   "label": "KlogAcpiBufferLimit"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>      "pattern": "ACPI Error.*Method (execution|parse\/execution) failed.*AE_AML_BUFFER_LIMIT",
>      "advice": "Method failed: ResourceSourceIndex is present but ResourceSource is not.",
>      "label": "KlogAcpiBufferLimit"
>

Acked-by: Alex Hung <alex.hung at canonical.com>