[PATCH] apci: apicinstance: clean up smatch warning

Colin King colin.king at canonical.com
Wed Jan 16 01:01:16 UTC 2013


From: Colin Ian King <colin.king at canonical.com>

smatch gets confused by the use of count to check if the madt table
has been set and the code is a little bit clearer if we just check
to see if the table is not set by checking if it is NULL.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/apicinstance/apicinstance.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/acpi/apicinstance/apicinstance.c b/src/acpi/apicinstance/apicinstance.c
index 245aa48..d2376de 100644
--- a/src/acpi/apicinstance/apicinstance.c
+++ b/src/acpi/apicinstance/apicinstance.c
@@ -43,7 +43,7 @@ static int apicinstance_test1(fwts_framework *fw)
 				table->name,
 				(unsigned long long)table->addr,
 				(int)table->length);
-			if (count == 0)
+			if (first_madt_table == NULL)
 				first_madt_table = table;
 			else {
 				if ((first_madt_table->length == table->length) &&
-- 
1.8.0




More information about the fwts-devel mailing list