NACK: [PATCH] uefi: uefirtvariable: fix build failure on 32 bit systems

Colin Ian King colin.king at canonical.com
Fri Jan 4 12:13:54 UTC 2013


On 20/12/12 10:36, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Fix build failure on 32 bit systems cause by not using ULL.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/uefi/uefirtvariable/uefirtvariable.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
> index 1599c5b..2a9db0b 100644
> --- a/src/uefi/uefirtvariable/uefirtvariable.c
> +++ b/src/uefi/uefirtvariable/uefirtvariable.c
> @@ -41,7 +41,7 @@
>   }
>
>   #define EFI_SUCCESS		0
> -#define EFI_NOT_FOUND		(14 | (1UL << 63))
> +#define EFI_NOT_FOUND		(14 | (1ULL << 63))
>
>   #define MAX_DATA_LENGTH		1024
>
>
As per Keng-Yu's comments, I'm NACK'ing my own patch.



More information about the fwts-devel mailing list