[PATCH] cpu: cpufreq: tidy up information message formatting
Keng-Yu Lin
kengyu at canonical.com
Wed Feb 20 05:48:17 UTC 2013
On Tue, Feb 19, 2013 at 7:13 PM, Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Tidy up information messages - remove \n and emit each line
> individually to ensure formatted logging in xml and html looks sane.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> src/cpu/cpufreq/cpufreq.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/src/cpu/cpufreq/cpufreq.c b/src/cpu/cpufreq/cpufreq.c
> index 94f2060..fd37b9d 100644
> --- a/src/cpu/cpufreq/cpufreq.c
> +++ b/src/cpu/cpufreq/cpufreq.c
> @@ -619,13 +619,12 @@ static int cpufreq_test1(fwts_framework *fw)
> "various frequency states (P-states) that the BIOS advertises "
> "for the processor. For each processor/frequency combination, "
> "a quick performance value is measured. The test then validates that:");
> - fwts_log_info_verbatum(fw,
> - " 1) Each processor has the same number of frequency states\n"
> - " 2) Higher advertised frequencies have a higher performance\n"
> - " 3) No duplicate frequency values are reported by the BIOS\n"
> - " 4) Is BIOS wrongly doing Sw_All P-state coordination across cores\n"
> - " 5) Is BIOS wrongly doing Sw_Any P-state coordination across cores\n");
> -
> + fwts_log_info_verbatum(fw, " 1. Each processor has the same number of frequency states.");
> + fwts_log_info_verbatum(fw, " 2. Higher advertised frequencies have a higher performance.");
> + fwts_log_info_verbatum(fw, " 3. No duplicate frequency values are reported by the BIOS.");
> + fwts_log_info_verbatum(fw, " 4. BIOS doing Sw_All P-state coordination across cores.");
> + fwts_log_info_verbatum(fw, " 5. BIOS doing Sw_Any P-state coordination across cores.");
> + fwts_log_nl(fw);
>
> /* First set all processors to their lowest speed */
> if ((dir = opendir(FWTS_CPU_PATH)) == NULL) {
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu at canonical.com>
More information about the fwts-devel
mailing list