ACK: [PATCH] dmi: change max value of "Upgrade" field" from 0x2a to 0x2c (LP: #1263634)

Colin Ian King colin.king at canonical.com
Mon Dec 23 11:29:32 UTC 2013


On 23/12/13 08:37, Alex Hung wrote:
> In SMBIOS spec 2.8, Processor Information's (Type 4) "Processor Upgrade field
> is ranged from 0x01 to 0x2c.
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index ab7d045..f1ecc98 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -815,7 +815,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  			dmi_min_max_uint8_check(fw, table, addr, "Processor Type", hdr, 0x5, 0x1, 0x6);
>  			dmi_str_check(fw, table, addr, "Processor Manufacturer", hdr, 0x7);
>  			dmi_str_check(fw, table, addr, "Processor Version", hdr, 0x10);
> -			dmi_min_max_uint8_check(fw, table, addr, "Upgrade", hdr, 0x19, 0x1, 0x2a);
> +			dmi_min_max_uint8_check(fw, table, addr, "Upgrade", hdr, 0x19, 0x1, 0x2c);
>  			if (hdr->length < 0x23)
>  				break;
>  			dmi_str_check(fw, table, addr, "Serial Number", hdr, 0x20);
> 
Thanks for spotting that,

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list