ACK: [PATCH] cpu: microcode: test should skip if no microcound found (LP: #1259900)

Alex Hung alex.hung at canonical.com
Thu Dec 12 09:43:46 UTC 2013


On 12/11/2013 08:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> If microcode is not found we should skip the test rather than not report
> a pass or fail.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/cpu/microcode/microcode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c
> index 8794c6c..d9dad9b 100644
> --- a/src/cpu/microcode/microcode.c
> +++ b/src/cpu/microcode/microcode.c
> @@ -288,7 +288,7 @@ static int microcode_test1(fwts_framework *fw)
>   		if (passed > 0)
>   			fwts_passed(fw, "%d CPU(s) have the latest microcode loaded.", passed);
>   		else
> -			fwts_log_info(fw, "Could not determine from kernel log if latest microcode has been loaded.");
> +			fwts_skipped(fw, "Could not determine from kernel log if latest microcode has been loaded.");
>   	}
>
>   	closedir(dir);
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list