[PATCH][RESEND] UEFI: move the UEFI tests into the UEFI categroy (LP:#1207200)
IvanHu
ivan.hu at canonical.com
Wed Aug 14 04:08:52 UTC 2013
On 08/04/2013 06:30 PM, Matt Fleming wrote:
> On Sat, 03 Aug, at 10:10:43AM, Colin Ian King wrote:
>> This is more like it. The changes are good. My concern is that the
>> potentially damaging "unsafe" tests are enabled for the --all option
>> which may be a risk. But "--all" does mean all, so that is fair
>> really I guess.
>>
>> So, I'm happy with these changes as long as we believe the risk of
>> enabling the "unsafe" tests with the --all option is low enough.
>> Otherwise, perhaps we should remove unsafe tests from --all just to
>> avoid potentially bricking users machines. So anyone like to also
>> comment on that?
>
> I guess it comes down to who we expect to run --all, and whether they
> would be able to recover their machines if they become bricks.
>
> For example, when running fwts at UEFI plugfests we *want* users to
> trigger any serious bugs, without making it unnecessarily complicated to
> run all the tests, including the unsafe ones.
>
> FWIW, I'm all for including the unsafe tests in --all provided that the
> change is made blatantly obvious, so that users are not caught unawares.
>
I suggest we could add another option, for example --all-safe, which
excludes these unsafe tests. Just let --all run all tests, and users who
don't want to run these unsafe tests could use --all-safe for all safe
tests.
Ivan
More information about the fwts-devel
mailing list