[PATCH 0/2] acpi: increase delays for s3 and s4 to make tests less aggressive

Colin Ian King colin.king at canonical.com
Mon Apr 29 15:59:38 UTC 2013


On 29/04/13 00:31, Alex Hung wrote:
> The default delays for s3 and s4 are too short and too aggressive, and many
> reported failures are fixed by simply increases the delays. If the delays
> are too short, the bottlenecks of the tests depend on hardware designs, ex.
> whether mainboards stablize fast enough when powers are removed, and OS
> behaviours, ex. whether drivers and services are loaded. Increasing the delays
> can reduce the dependency.

The original idea was to make S3 + S4 tests aggressive to catch out 
failures, so I think the defaults are sane because that the original 
intention.

>
> Alex Hung (2):
>    acpi: s3: increase delays to match user scanerio and to reduce false
>         non-firmware-related failures.
>    acpi: s4: increase delays to match user scanerio and to reduce false
>         non-firmware-related failures.
>
>   src/acpi/s3/s3.c |    6 +++---
>   src/acpi/s4/s4.c |    4 ++--
>   2 files changed, 5 insertions(+), 5 deletions(-)
>




More information about the fwts-devel mailing list