[PATCH] acpi: checksum: rename the test name from "checksum to "acpichecksum"

Alex Hung alex.hung at canonical.com
Thu Apr 25 02:43:59 UTC 2013


The name "checksum" is too generic. The rename can help a user to understand
that the test targets ACPI tables and verifies the table checksum.

Signed-off-by: Alex Hung <alex.hung at canonical.com>
---
 src/acpi/checksum/checksum.c |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/acpi/checksum/checksum.c b/src/acpi/checksum/checksum.c
index e56ca66..a8ec15c 100644
--- a/src/acpi/checksum/checksum.c
+++ b/src/acpi/checksum/checksum.c
@@ -26,7 +26,7 @@
 
 #include "fwts.h"
 
-static void checksum_rsdp(fwts_framework *fw, fwts_acpi_table_info *table)
+static void acpi_checksum_rsdp(fwts_framework *fw, fwts_acpi_table_info *table)
 {
 	uint8_t checksum;
 	fwts_acpi_table_rsdp *rsdp = (fwts_acpi_table_rsdp*)table->data;
@@ -89,7 +89,7 @@ static void checksum_rsdp(fwts_framework *fw, fwts_acpi_table_info *table)
 
 }
 
-static int checksum_scan_tables(fwts_framework *fw)
+static int acpi_checksum_scan_tables(fwts_framework *fw)
 {
 	int i;
 
@@ -108,7 +108,7 @@ static int checksum_scan_tables(fwts_framework *fw)
 		hdr = (fwts_acpi_table_header*)table->data;
 
 		if (strcmp("RSDP", table->name) == 0) {
-			checksum_rsdp(fw, table);
+			acpi_checksum_rsdp(fw, table);
 			continue;
 		}
 
@@ -140,19 +140,20 @@ static int checksum_scan_tables(fwts_framework *fw)
 	return FWTS_OK;
 }
 
-static int checksum_test1(fwts_framework *fw)
+static int acpi_checksum_test1(fwts_framework *fw)
 {
-	return checksum_scan_tables(fw);
+	return acpi_checksum_scan_tables(fw);
 }
 
-static fwts_framework_minor_test checksum_tests[] = {
-	{ checksum_test1, "Check ACPI table checksums." },
+static fwts_framework_minor_test acpi_checksum_tests[] = {
+	{ acpi_checksum_test1, "Check ACPI table checksums." },
 	{ NULL, NULL }
 };
 
 static fwts_framework_ops checksum_ops = {
 	.description = "Check ACPI table checksum.",
-	.minor_tests = checksum_tests
+	.minor_tests = acpi_checksum_tests
 };
 
-FWTS_REGISTER("checksum", &checksum_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH);
+FWTS_REGISTER("acpichecksum", &checksum_ops,
+		FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH);
-- 
1.7.9.5




More information about the fwts-devel mailing list