ACK: [PATCH] bios: mtrr: add uncached string for DEFAULT type
Colin Ian King
colin.king at canonical.com
Thu Apr 18 07:17:10 UTC 2013
On 17/04/13 10:52, Alex Hung wrote:
> In Section 11.11 of Intel® 64 and IA-32 Architectures Software Developer's
> Manual Volume 3, it implies physical memory unconfigured in MTRR is uncached.
>
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
> src/bios/mtrr/mtrr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bios/mtrr/mtrr.c b/src/bios/mtrr/mtrr.c
> index 0a83d58..284d153 100644
> --- a/src/bios/mtrr/mtrr.c
> +++ b/src/bios/mtrr/mtrr.c
> @@ -73,7 +73,7 @@ static char *cache_to_string(int type)
> if (type & WRITE_PROTECT)
> strcat(str," Write-Protect");
> if (type & DEFAULT)
> - strcat(str," Default");
> + strcat(str," Default (Most probably Uncached)");
> if (type & UNKNOWN)
> strcat(str," Unknown");
> return str;
>
This clarifies the default setting as discussed in IRC yesterday.
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the fwts-devel
mailing list